-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test cases for DB query parsing and sanitization #1923
Open
alanwest
wants to merge
11
commits into
open-telemetry:main
Choose a base branch
from
alanwest:alanwest/db-test-cases
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Feb 21, 2025
trask
reviewed
Feb 21, 2025
trask
reviewed
Feb 21, 2025
lmolkova
reviewed
Mar 10, 2025
trask
reviewed
Mar 12, 2025
lmolkova
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #984
Opening this PR to start a discussion for how we want to format test cases for database query parsing and sanitization.
Each test case includes the following fields
name
identifying the test casequery
statement representing the inputdb.system.name
indicates which dialect that the test case targets. A value ofother_sql
indicates it is applicable to all dialects.db.query.text
values.IN
clauses MAY be collapsed. So, bothIN (?)
andIN (?,?,?)
are valid.db.query.summary
represents whatdb.query.summary
should equalFor this first iteration I would like to settle on the format for presenting these test cases. In follow ups we can expand the test cases and also handle additional idiosyncrasies of other dialects.